RDKTV-39792:[RDKV] Xumo TV devices with older builds failing to upgrade due to image verification failure error by mkadinti · Pull Request #208 · rdkcentral/rdkfwupdater

mkadinti · 2026-03-10T07:11:31Z

No description provided.

RDKTV-39792:[RDKV] Xumo TV devices with older builds failing to upgrade due to image verification failure error

* RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - updating testClient for - signals option - core debug * RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - updating testClient for - signals option - core debug * RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - updating testClient for - signals option - core debug * RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - updating testClient for - signals option - core debug * RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - updating testClient for - signals option - core debug * RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - updating testClient for - signals option - core debug - tral fix * RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - Enhanced testClient * RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - img validation enhancement * RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - unittests * RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - PR Clean up * Delete src/test/rdkfw_test_client.c * RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - l2 unittests * RDK-58925:[RDK-E] Run fwupdater as a Daemon with D-Bus API Handling - Coverity fixes * Uncomment git commands in cov_build.sh * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-compile fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-Asyn task fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-Asyn task fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- blackduck error fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- blackduck error fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- XML fiux * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- XML fiux * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-Issue fix in integrating rdkv_upgrade_request() * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- Core Debug in downloadFile() * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- Core Debug in downloadFile() * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- Core Debug in downloadFile() * Refactor RdkUpgradeContext_t structure and comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback - debug logs * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback - debug logs * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback - clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback - clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback - clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback - clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Issue fix in progress callback - clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-UT Empty field check * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates-Enahanced duplicate request handlign - DownloadFW * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API validations * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API validations * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - flashImage() integrated * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - Compilation fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - Compilation fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - dev testing - validation failed fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - dev testing - FlashImge - null server_url fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - dev testing - test client update and Review comments addressing * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - dev testing - testClient Update * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - dev testing - testClient log enhancement * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - dev testing - testClient log enhancement - removed concurrent test cases * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - Blackduck fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - coverity fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - added header in testClient.c * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - Coverity fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - Coverity fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - modifications in adressing comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - modifications in adressing comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - modifications in adressing comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - modifications in adressing comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - L1 fixed for exiting tests * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - Unit tests for XConf Fetching * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - Unit tests for XConf Fetching * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - reveritng .md files * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - reverting README.md file removal * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- partial L1 tests * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 for cache helper functions * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- DownlaodFirmware test cases * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- DownlaodFirmware test cases * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- DownlaodFirmware test cases * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug - 2 * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug - 2 * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug - 3 * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug - 4 * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug - 5 * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 for CheckForUpdate * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 for CheckForUpdate * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 for CheckForUpdate * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 clean up - compile fail fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 clean up - L2 for Basic register, unregister and CheckForUpdate * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 clean up - L1 - PR compile fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Seperated integration tests for Register * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Seperated integration tests for Register * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- updated run_l2.sh * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Seperated Integration tests fot UnregisterProcess * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Seperated Integration tests fot UnregisterProcess * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Seperated Integration tests for CheckForUpdate * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing Review comments on cov_build.sh * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments by copilot in src/dbus/rdkv_dbus_server.c * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Review reports by Copilot * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Review reports by Copilot * Update Initial_REVIEW_rdkv_dbus_server.md * Update DEMO_Comments.md * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT - 43% achieved * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT - 59.2% achieved * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT - 64.1% achieved * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments by copilot in src/dbus/rdkv_dbus_server.c * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 for Download Firmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 for Download Firmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 updated for DownloadFirmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 updated for DownloadFirmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 updated for UpdateFirmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 updated for UpdateFirmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 updated for UpdateFirmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR cleanup * Delete DEMO_Comments.md * Delete Initial_REVIEW_rdkv_dbus_server.md * Delete LINK_TIME_SYMBOL_INTERPOSITION.md * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR cleanup * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- rdk_logger_ext_init applied * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- rdk_logger_ext_init applied * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- rdk_logger_ext_init applied * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- rdk_logger_ext_init applied * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- rdk_logger_ext_init applied * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT fix after coverity fixes * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT fix after coverity fixes * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT failure fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 failure fix - to compile with rdk_logger fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 failure fix - to compile with rdk_logger fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 failure fix - to compile with rdk_logger fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60261:Implement software update service layer library- Implement RegisterProcess- adding rdkFwupdateMgr_client.h header * RDK-60261:Implement software update service layer library- Implement RegisterProcess- adding rdkFwupdateMgr_client.h header * Update src/device_status_helper.c Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_CheckForUpdate.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_DownloadFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_DownloadFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_UpdateFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_UpdateFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_DownloadFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_DownloadFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * RDK-60261:Implement software update service layer library- Implement RegisterProcess- adding initial src files * Update test/functional-tests/tests/test_dbus_DownloadFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * RDK-60261:Implement software update service layer library- Implement RegisterProcess- Updated public header * RDK-60261:Implement software update service layer library- Implement RegisterProcess- Updated public header * RDK-60261:Implement software update service layer library- Implement RegisterProcess- Updated public header * Update rdkFwupdateMgr_client.h * Update rdkFwupdateMgr_client.h * Update rdkFwupdateMgr_client.h - input params to Download and Update FW APIs * Update rdkFwupdateMgr_client.h * Update rdkFwupdateMgr_client.h * RDK-60767:Address Review comments / change in design for CheckForUpdate * RDK-60767:Address Review comments / change in design for CheckForUpdate * RDK-60767:Address Review comments / change in design for CheckForUpdate * RDK-60767:Address Review comments / change in design for CheckForUpdate * RDK-60767:Address Review comments / change in design for CheckForUpdate - optout * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- addressing copilot review * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- addressing copilot review * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update librdkFwupdateMgr/include/rdkFwupdateMgr_client.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- addressing copilot review * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- fixing UT * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- fixing UT * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- fixing UT * Delete EXIT_CALL_ELIMINATION_GUIDE.md * Delete UNITTEST_CHANGES_EXPLAINED.md * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * RDK-60261:Implement software update service layer library-Addressing copilot reviews * RDK-60261:Implement software update service layer library-Addressing copilot reviews * RDKEMW-14991:[Xione UK] - Firmware download should not happen when throttle speed is set to 0 * RDKEMW-14991:[Xione UK] - Firmware download should not happen when throttle speed is set to 0 * RDKEMW-14991:[Xione UK] - Firmware download should not happen when throttle speed is set to 0 * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * Update rdkFwupdateMgr_client.h * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library- removed tests that were written for old CHeckForUpdate and Downlaod Firmware design * RDK-60261:Implement software update service layer library- removed tests that were written for old CHeckForUpdate and Downlaod Firmware design * RDK-60261:Implement software update service layer library- Coverity issues --------- Co-authored-by: mkadinti <madhunarasimhulu@gmal.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Enable rdkfwmanager interface lib support

Release 1.6.0

Copilot

Pull request overview

This PR addresses upgrade failures on older Xumo TV builds by introducing explicit upgrade-library error codes (instead of exiting), improving error reporting, and enhancing D-Bus download behavior via cached XConf metadata. It also updates unit/functional test scaffolding and adds initial build/public-header wiring for a client library.

Changes:

Add upgrade-library error codes + rdkv_upgrade_strerror() and propagate fatal conditions via return codes instead of exit(1).
Update daemon/CLI flows to handle negative “library error” returns and improve DownloadFirmware URL resolution using in-memory/file XConf cache.
Adjust test mocks/build scripts and add an initial client library header + build target wiring.

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`unittest/test_dbus_fake.cpp`	Updates copyright year in unit test file header.
`unittest/rdkfwupdatemgr_main_flow_gtest.cpp`	Switches `g_DeviceUtilsMock` global handling to shared global header/pointer.
`unittest/rdkFwupdateMgr_handlers_gtest.cpp`	Removes/adjusts tests and updates mock lambda signatures to `const RdkUpgradeContext_t*`.
`unittest/mocks/rdkFwupdateMgr_mock.h`	Updates mock interface signature for `rdkv_upgrade_request` to match const-correct production API.
`unittest/mocks/rdkFwupdateMgr_mock.cpp`	Moves device utils stubs out; adds handler dependency stubs (incl. `rdkv_upgrade_strerror`, `getOPTOUTValue`).
`unittest/mocks/deviceutils_mock.cpp`	Defines `g_DeviceUtilsMock` global pointer in one place for all test binaries.
`unittest/mocks/dbus_handlers_gmock.cpp`	Adds additional stubs for handler tests (DownloadFirmware/opt-out/strerror).
`unittest/miscellaneous_mock.cpp`	Aligns mock signatures (e.g., `checkAndEnterStateRed` now returns `int`) and adds strerror/handler stubs under test flags.
`unittest/deviceutils_mock_global.h`	New shared header declaring `extern DeviceUtilsMock *g_DeviceUtilsMock`.
`unittest/deviceutils/deviceutils_gtest.cpp`	Stops defining `g_DeviceUtilsMock` locally; relies on shared global.
`unittest/basic_rdkv_main_gtest.cpp`	Switches to shared `g_DeviceUtilsMock` declaration and includes new global header.
`unittest/Makefile.am`	Updates unit test source lists and mock linkage (notably adds `deviceutils_mock.cpp` to some targets).
`test/functional-tests/tests/test_dbus_UpdateFirmware.py`	Minor cleanup of unused variables/imports in UpdateFirmware functional test.
`test/functional-tests/tests/test_dbus_DownloadFirmware.py`	Changes helper import style and adjusts some local variable usage/exception handling.
`test/functional-tests/tests/test_dbus_CheckForUpdate.py`	Changes helper import style and removes an unused import.
`src/rdkv_upgrade.c`	Adds `rdkv_upgrade_strerror`, converts fatal exits into return codes, and checks `checkAndEnterStateRed()` return.
`src/rdkv_main.c`	Handles negative library errors from `rdkv_upgrade_request` (CLI exits on fatal library errors).
`src/rdkFwupdateMgr.c`	Handles negative library errors from `rdkv_upgrade_request` (daemon logs and continues).
`src/include/rdkv_upgrade.h`	Introduces negative-valued library error enum and declares `rdkv_upgrade_strerror(int)`.
`src/include/device_status_helper.h`	Changes `checkAndEnterStateRed` signature to return `int`.
`src/device_status_helper.c`	Implements `checkAndEnterStateRed` as non-exiting and returns status to caller.
`src/dbus/rdkv_dbus_server.c`	Updates DownloadFirmware validation and resolves effective download URL via in-memory/file XConf cache.
`src/dbus/rdkFwupdateMgr_handlers.h`	Updates DownloadFirmware API signature and exposes cache helper APIs for daemon/tests.
`src/dbus/rdkFwupdateMgr_handlers.c`	Adds global in-memory XConf cache + opt-out response helper and adjusts cache saving behavior.
`src/chunk.c`	Converts “force exit” behavior into negative library return code and includes upgrade error header.
`run_l2.sh`	Removes `--enable-extended-logger` from configure invocation.
`librdkFwupdateMgr/include/rdkFwupdateMgr_client.h`	Adds initial public client API header for D-Bus clients.
`cov_build.sh`	Adjusts build steps and removes `--enable-extended-logger`.
`Makefile.am`	Adds `librdkFwupdateMgr.la` target and installs its public header.
`CHANGELOG.md`	Updates changelog with new release notes entries.

Comments suppressed due to low confidence (2)

test/functional-tests/tests/test_dbus_DownloadFirmware.py:33

The import was changed to import rdkfw_test_helper, but the module’s helpers are still used unqualified (e.g., initial_rdkfw_setup(), remove_file()). This will raise NameError when running the tests. Please either switch back to from rdkfw_test_helper import ... or prefix all helper calls with rdkfw_test_helper..

import rdkfw_test_helper

# D-Bus Configuration
DBUS_SERVICE_NAME = "org.rdkfwupdater.Service"
DBUS_OBJECT_PATH = "/org/rdkfwupdater/Service"
DBUS_INTERFACE = "org.rdkfwupdater.Interface"
DAEMON_BINARY = "/usr/local/bin/rdkFwupdateMgr"

test/functional-tests/tests/test_dbus_CheckForUpdate.py:32

The import was changed to import rdkfw_test_helper, but helper functions are still called unqualified (e.g., rename_file(), write_on_file(), remove_file()). This will raise NameError when running the tests. Please either revert to from rdkfw_test_helper import ... or prefix calls with rdkfw_test_helper..

import json

import rdkfw_test_helper

# D-Bus Configuration
DBUS_SERVICE_NAME = "org.rdkfwupdater.Service"
DBUS_OBJECT_PATH = "/org/rdkfwupdater/Service"
DBUS_INTERFACE = "org.rdkfwupdater.Interface"
DAEMON_BINARY = "/usr/local/bin/rdkFwupdateMgr"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-10T07:22:21Z

+# Client Library Configuration - librdkFwupdateMgr.la
+librdkFwupdateMgr_la_SOURCES = \
+     ${top_srcdir}/librdkFwupdateMgr/src/
+    #${top_srcdir}/librdkFwupdateMgr/src/handle_mgr.c \
+    #${top_srcdir}/librdkFwupdateMgr/src/handle_registry.c \
+    #${top_srcdir}/librdkFwupdateMgr/src/dbus_client.c \
+    #${top_srcdir}/librdkFwupdateMgr/src/api_impl.c


librdkFwupdateMgr_la_SOURCES currently lists a directory (${top_srcdir}/librdkFwupdateMgr/src/) instead of source files. Automake will treat this as an invalid source entry and fail the build. Please replace it with the concrete .c/.cpp files (or remove the library target until sources are added).

Copilot · 2026-03-10T07:22:21Z

+extern "C" int rdkFwupdateMgr_downloadFirmware(...)
+{
+    return 0;
+}


The test stub rdkFwupdateMgr_downloadFirmware(...) is declared as variadic and returns int, but the production header declares it as returning DownloadFirmwareResult with a fixed parameter list. If this symbol is ever referenced from C code compiled against the header, the return-type/ABI mismatch can cause crashes. Please change the stub to match the real signature and return type (or remove it if unused).

Copilot · 2026-03-10T07:22:22Z

+extern "C" int getOPTOUTValue()
+{
+    return 0;
+}


getOPTOUTValue is stubbed here with no parameters, but production code calls getOPTOUTValue(const char *path) (see handlers.c forward declaration). In C++ this mismatch defeats type checking and can be undefined behavior on some ABIs. Please update the stub signature to accept const char * (and keep it consistent with other mocks that also define this function).

Copilot · 2026-03-10T07:22:22Z

+    // Mock for rdkv_upgrade_strerror - converts error codes to human-readable strings
+    // Used by rdkFwupdateMgr.c for error logging
+    const char* rdkv_upgrade_strerror(int error) {
+        switch(error) {
+            case 0:  // RDKV_UPGRADE_SUCCESS
+                return "Success";
+            case -1:  // RDKV_UPGRADE_ERROR_THROTTLE_ZERO
+                return "Throttle speed set to 0 - download blocked";
+            case -2:  // RDKV_UPGRADE_ERROR_FORCE_EXIT
+                return "Force exit requested";
+            default:
+                if (error > 0) {
+                    return "CURL error";
+                }
+                return "Unknown library error";
+        }


The rdkv_upgrade_strerror stub uses -1/-2 for the new library error cases, but the updated public enum in rdkv_upgrade.h defines RDKV_UPGRADE_ERROR_THROTTLE_ZERO=-100 and RDKV_UPGRADE_ERROR_FORCE_EXIT=-101. This will produce incorrect messages/branching in tests that validate error handling. Please update the stub to use the new constants (or include rdkv_upgrade.h and switch on the enum values).

Copilot · 2026-03-10T07:22:22Z

+    const char* rdkv_upgrade_strerror(int error) {
+        switch(error) {
+            case 0: return "Success";
+            case -1: return "Throttle speed set to 0";
+            case -2: return "Force exit requested";
+            default:
+                if (error > 0) return "CURL error";
+                return "Unknown library error";
+        }


This rdkv_upgrade_strerror stub also maps the throttle/force-exit errors to -1/-2, but production now uses RDKV_UPGRADE_ERROR_THROTTLE_ZERO=-100 and RDKV_UPGRADE_ERROR_FORCE_EXIT=-101 (see src/include/rdkv_upgrade.h). Please update the cases to match the new error codes so unit tests reflect real behavior.

* RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - modifications in adressing comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - modifications in adressing comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - L1 fixed for exiting tests * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - Unit tests for XConf Fetching * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - Unit tests for XConf Fetching * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - reveritng .md files * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation - reverting README.md file removal * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- partial L1 tests * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 for cache helper functions * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- DownlaodFirmware test cases * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- DownlaodFirmware test cases * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- DownlaodFirmware test cases * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug - 2 * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug - 2 * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug - 3 * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug - 4 * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 xconf cache load functions- UT compile fail debug - 5 * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 for CheckForUpdate * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 for CheckForUpdate * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 for CheckForUpdate * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 clean up - compile fail fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 clean up - L2 for Basic register, unregister and CheckForUpdate * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L1 clean up - L1 - PR compile fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Seperated integration tests for Register * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Seperated integration tests for Register * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- updated run_l2.sh * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Seperated Integration tests fot UnregisterProcess * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Seperated Integration tests fot UnregisterProcess * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Seperated Integration tests for CheckForUpdate * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing Review comments on cov_build.sh * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments by copilot in src/dbus/rdkv_dbus_server.c * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Review reports by Copilot * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Review reports by Copilot * Update Initial_REVIEW_rdkv_dbus_server.md * Update DEMO_Comments.md * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT - 43% achieved * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT - 59.2% achieved * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT - 64.1% achieved * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Adressing review comments by copilot in src/dbus/rdkv_dbus_server.c * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 for Download Firmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 for Download Firmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 updated for DownloadFirmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 updated for DownloadFirmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 updated for UpdateFirmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 updated for UpdateFirmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 updated for UpdateFirmware * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR cleanup * Delete DEMO_Comments.md * Delete Initial_REVIEW_rdkv_dbus_server.md * Delete LINK_TIME_SYMBOL_INTERPOSITION.md * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR cleanup * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- run_l2.sh changes to start dbus deamon * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Coverity issue fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- Review comments * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- rdk_logger_ext_init applied * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- rdk_logger_ext_init applied * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- rdk_logger_ext_init applied * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- rdk_logger_ext_init applied * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- rdk_logger_ext_init applied * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT fix after coverity fixes * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT fix after coverity fixes * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- UT failure fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 failure fix - to compile with rdk_logger fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 failure fix - to compile with rdk_logger fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- L2 failure fix - to compile with rdk_logger fix * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- removed adapted changes from rdk_logger * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60065:[RDK-E] Implement Firmware Download & Install API for Event-Driven Firmware Updates- UpdateFirmware API Implementation- PR clean up * RDK-60261:Implement software update service layer library- Implement RegisterProcess- adding rdkFwupdateMgr_client.h header * RDK-60261:Implement software update service layer library- Implement RegisterProcess- adding rdkFwupdateMgr_client.h header * Update src/device_status_helper.c Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_CheckForUpdate.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_DownloadFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_DownloadFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_UpdateFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_UpdateFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_DownloadFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/functional-tests/tests/test_dbus_DownloadFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * RDK-60261:Implement software update service layer library- Implement RegisterProcess- adding initial src files * Update test/functional-tests/tests/test_dbus_DownloadFirmware.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * RDK-60261:Implement software update service layer library- Implement RegisterProcess- Updated public header * RDK-60261:Implement software update service layer library- Implement RegisterProcess- Updated public header * RDK-60261:Implement software update service layer library- Implement RegisterProcess- Updated public header * Update rdkFwupdateMgr_client.h * Update rdkFwupdateMgr_client.h * Update rdkFwupdateMgr_client.h - input params to Download and Update FW APIs * Update rdkFwupdateMgr_client.h * Update rdkFwupdateMgr_client.h * RDK-60767:Address Review comments / change in design for CheckForUpdate * RDK-60767:Address Review comments / change in design for CheckForUpdate * RDK-60767:Address Review comments / change in design for CheckForUpdate * RDK-60767:Address Review comments / change in design for CheckForUpdate * RDK-60767:Address Review comments / change in design for CheckForUpdate - optout * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- addressing copilot review * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- addressing copilot review * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update librdkFwupdateMgr/include/rdkFwupdateMgr_client.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- addressing copilot review * RDK-60527:Implement registerProcess and unregisterProcess APIs * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- fixing UT * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- fixing UT * RDK-60527:Implement registerProcess and unregisterProcess APIs- example plugin * RDK-60768:Modify deamon logic to handle exit() scenarios in shared libraries- fixing UT * RDK-60527:Implement registerProcess and unregisterProcess APIs- example plugin * RDK-60528:Add checkForUpdate API with Callback Support * RDKTV-39792:[RDKV] Xumo TV devices with older builds failing to upgrade due to image verification failure error * RDK-60527:Implement registerProcess and unregisterProcess APIs * RDK-60529-Implement downloadFirmware API with Progress Callbacks * RDK-60529-Implement downloadFirmware API with Progress Callbacks * RDK-60529-Implement downloadFirmware API with Progress Callbacks * RDK-60529-Implement downloadFirmware API with Progress Callbacks * RDK-60529-Implement downloadFirmware API with Progress Callbacks * RDK-60529-Implement downloadFirmware API with Progress Callbacks * RDK-60529-Implement downloadFirmware API with Progress Callbacks * Delete EXIT_CALL_ELIMINATION_GUIDE.md * Delete UNITTEST_CHANGES_EXPLAINED.md * RDK-60529-Implement downloadFirmware API with Progress Callbacks * RDK-60529-Implement downloadFirmware API with Progress Callbacks- clean up * RDK-60529-Implement downloadFirmware API with Progress Callbacks- Fix for example_plugin * RDK-60529-Implement downloadFirmware API with Progress Callbacks- Fix for example_plugin * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * RDK-60261:Implement software update service layer library-Addressing copilot reviews * RDK-60261:Implement software update service layer library-Addressing copilot reviews * Update rdkFwupdateMgr_log.c * RDKEMW-14991:[Xione UK] - Firmware download should not happen when throttle speed is set to 0 * RDKEMW-14991:[Xione UK] - Firmware download should not happen when throttle speed is set to 0 * RDKEMW-14991:[Xione UK] - Firmware download should not happen when throttle speed is set to 0 * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library-fixing example_plugin * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * Update rdkFwupdateMgr_client.h * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library- UT fix- added mock for a new function * RDK-60261:Implement software update service layer library- removed tests that were written for old CHeckForUpdate and Downlaod Firmware design * RDK-60261:Implement software update service layer library- removed tests that were written for old CHeckForUpdate and Downlaod Firmware design * RDK-60261:Implement software update service layer library- Coverity issues * RDK-60261:Implement software update service layer library-fixing example_plugin * RDK-60529-Implement downloadFirmware API with Progress Callbacks * RDK-60529-Implement downloadFirmware API with Progress Callbacks * RDK-60529-Implement downloadFirmware API with Progress Callbacks * RDK-60529-Implement downloadFirmware API with Progress Callbacks- updated MAX_PENDING_CALLBACKS to 30 form 64 * RDK-60529-Implement downloadFirmware API with Progress Callbacks- updated in librdkFwupdateMgr/src/rdkFwupdateMgr_async.c librdkFwupdateMgr/src/rdkFwupdateMgr_async_internal.h for coverity * RDK-60529-Implement downloadFirmware API with Progress Callbacks- updated in librdkFwupdateMgr/src/rdkFwupdateMgr_async.c librdkFwupdateMgr/src/rdkFwupdateMgr_async_internal.h for coverity * RDK-60529-Implement downloadFirmware API with Progress Callbacks- PR clean up -removed dead code * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * RDK-60529-Implement downloadFirmware API with Progress Callbacks- PR clean up -removed dead code * RDK-60529-Implement downloadFirmware API with Progress Callbacks- PR clean up -removed dead code * RDK-60261:Implement software update service layer library-fixing example_plugin * RDK-60261:Implement software update service layer library-fixing example_plugin * RDK-60261:Implement software update service layer library-fixing exampl_plugin * RDK-60261:Implement software update service layer library-fixing exampl_plugin * RDK-60261:Implement software update service layer library-fixing exampl_plugin * RDK-60261:Implement software update service layer library-fixing exampl_plugin * RDK-60261:Implement software update service layer library-fixing exampl_plugin- revert if the changes are not wotking * RDK-60261:Implement software update service layer library-fixing exampl_plugin- revert if the changes are not working - 2 * RDK-60261:Implement software update service layer library-fixing exampl_plugin- revert if the changes are not working - 3 * Delete test/phase6_complete_validation.sh * Delete test/memory_validation.sh * RDK-60261:Implement software update service layer library-fixing exampl_plugin-copilot review for FirmwareInterfaceContext * RDK-60261:Implement software update service layer library-fixing exampl_plugin- example_plugin updateFirmware locOfFirmware fix * RDK-60261:Implement software update service layer library-fixing exampl_plugin- example_plugin updateFirmware locOfFirmware fix * RDK-60261:Implement software update service layer library-fixing exampl_plugin- example_plugin updateFirmware locOfFirmware fix * Revert "RDK-60261:Implement software update service layer library-fixing exampl_plugin- example_plugin updateFirmware locOfFirmware fix" This reverts commit 303ff72. * Delete API_DOCUMENTATION_updateFirmware.md * Delete API_DOCUMENTATION_checkForUpdate.md * Delete API_DOCUMENTATION_downloadFirmware.md * Delete librdkFwupdateMgr/API_DOCUMENTATION_registerProcess.md * Delete librdkFwupdateMgr/API_DOCUMENTATION_unregisterProcess.md --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Added lib interface for damon

Release 1.6.1

Copilot

Pull request overview

Copilot reviewed 44 out of 44 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-11T14:39:45Z

+extern "C" int rdkFwupdateMgr_downloadFirmware(...)
+{
+    return 0;
+}
+
+extern "C" const char* rdkv_upgrade_strerror(int err)
+{
+    return "mock_error";
+}

+extern "C" int getOPTOUTValue()
+{
+    return 0;


The added stubs introduce ABI/signature mismatches that can cause crashes or undefined behavior at link/runtime. rdkFwupdateMgr_downloadFirmware is defined here as extern "C" int rdkFwupdateMgr_downloadFirmware(...), but the real symbol now returns DownloadFirmwareResult (a struct). Also getOPTOUTValue is defined with no parameters, but other code calls getOPTOUTValue(const char*). Because these are extern "C", the linker will happily bind the symbol and the call/return ABI will be wrong. Fix by matching the exact production signatures (including return type and parameters) or remove these stubs and rely on the existing ones in the appropriate mock files.

Copilot · 2026-03-11T14:39:46Z

+# Uses internal async implementation files
+rdkFwupdateMgr_async_refcount_gtest_SOURCES = rdkFwupdateMgr_async_refcount_gtest.cpp \
+    ../librdkFwupdateMgr/src/rdkFwupdateMgr_async.c \
+    ../librdkFwupdateMgr/src/rdkFwupdateMgr_async_api.c


*_SOURCES references ../librdkFwupdateMgr/src/rdkFwupdateMgr_async_api.c, but that file does not exist in the tree (the file present is rdkFwupdateMgr_api.c). As written, these new test targets will fail to build. Update the source list to the correct filename(s) and ensure any required test-only helpers are actually compiled into the binaries.

Suggested change

../librdkFwupdateMgr/src/rdkFwupdateMgr_async_api.c

../librdkFwupdateMgr/src/rdkFwupdateMgr_api.c

Copilot · 2026-03-11T14:39:46Z

+extern "C" {
+#include "rdkFwupdateMgr_client.h"
+// Internal testing APIs
+extern void rdkFwupdateMgr_async_init_for_test(void);
+extern void rdkFwupdateMgr_async_cleanup_for_test(void);
+extern int rdkFwupdateMgr_async_get_pending_count_for_test(void);
+extern int rdkFwupdateMgr_async_get_total_count_for_test(void);


This test file declares/uses several async test helper APIs and entry points (rdkFwupdateMgr_async_init_for_test, *_cleanup_for_test, *_get_pending_count_for_test, etc.) plus rdkFwupdateMgr_checkForUpdate_async, but none of these symbols exist in the current codebase (the public client API is checkForUpdate(...) in rdkFwupdateMgr_client.h). As-is, this file will not compile/link. Either rename the calls to match the actual public API, or add the required test-only exports (guarded by a macro) and compile them into this test target.

Copilot · 2026-03-11T14:39:47Z

+extern "C" {
+#include "rdkFwupdateMgr_client.h"
+// Internal testing APIs
+extern void rdkFwupdateMgr_async_init_for_test(void);
+extern void rdkFwupdateMgr_async_cleanup_for_test(void);
+extern void rdkFwupdateMgr_async_simulate_signal_for_test(
+    const char* status, const char* message, const char* version);
+}


This file depends on rdkFwupdateMgr_async_init_for_test/cleanup_for_test/simulate_signal_for_test and calls rdkFwupdateMgr_checkForUpdate_async(...), but those symbols are not defined anywhere in the repository (and rdkFwupdateMgr_client.h does not declare them). This will fail to compile/link. Please align the tests with the actual client API (checkForUpdate, signal subscription) or add the missing test hooks behind a compile-time flag and include them in the test target sources.

Copilot · 2026-03-11T14:39:47Z

+extern "C" {
+#include "rdkFwupdateMgr_client.h"
+// Internal testing APIs
+extern void rdkFwupdateMgr_async_init_for_test(void);
+extern void rdkFwupdateMgr_async_cleanup_for_test(void);
+extern void rdkFwupdateMgr_async_simulate_signal_for_test(
+    const char* status, const char* message, const char* version);
+extern int rdkFwupdateMgr_async_get_pending_count_for_test(void);
+}


This file declares/uses async test helper APIs (rdkFwupdateMgr_async_*_for_test) and calls rdkFwupdateMgr_checkForUpdate_async/_cancel, but these symbols are not present in the current codebase (the public API in rdkFwupdateMgr_client.h is checkForUpdate(...)). As-is, the test target will not compile/link. Either refactor the tests to use the actual API, or add/export the required async test hooks and include them in the build.

Copilot · 2026-03-11T14:39:47Z

+extern "C" {
+    // Include internal header for direct testing
+    // Note: In production, adjust include path as needed
+    #include "../librdkFwupdateMgr/src/rdkFwupdateMgr_async_internal.h"
+
+    // Expose internal functions for testing
+    extern void context_ref(AsyncCallbackContext *ctx);
+    extern void context_unref(AsyncCallbackContext *ctx);
+    extern AsyncCallbackRegistry g_async_registry;
+}


This refcount test appears to target a different/internal async implementation than the one currently in librdkFwupdateMgr: it includes rdkFwupdateMgr_async_internal.h but then uses AsyncCallbackContext, AsyncCallbackRegistry, and context_ref/context_unref, none of which are declared/defined in that header or anywhere else in the repo. This will not compile/link. Suggest either (a) updating the test to use the actual internal types/functions that exist in rdkFwupdateMgr_async.c, or (b) adding explicit test-only exports for the refcount helpers and the associated types behind a macro, and including them in the test target sources.

Copilot · 2026-03-11T14:39:48Z

+    // Mock for rdkv_upgrade_strerror - converts error codes to human-readable strings
+    // Used by rdkFwupdateMgr.c for error logging
+    const char* rdkv_upgrade_strerror(int error) {
+        switch(error) {
+            case 0:  // RDKV_UPGRADE_SUCCESS
+                return "Success";
+            case -1:  // RDKV_UPGRADE_ERROR_THROTTLE_ZERO
+                return "Throttle speed set to 0 - download blocked";
+            case -2:  // RDKV_UPGRADE_ERROR_FORCE_EXIT
+                return "Force exit requested";


rdkv_upgrade_strerror() in this mock uses -1 / -2 for the new library error codes, but production now defines RDKV_UPGRADE_ERROR_THROTTLE_ZERO = -100 and RDKV_UPGRADE_ERROR_FORCE_EXIT = -101 (see src/include/rdkv_upgrade.h). As a result, tests that log/interpret these errors will produce misleading messages and may not exercise the intended branches. Update the switch cases to match the new negative values (or use the enum constants).

Copilot · 2026-03-11T14:39:48Z

 from pathlib import Path

-from rdkfw_test_helper import *
+import rdkfw_test_helper


The import was changed from from rdkfw_test_helper import * to import rdkfw_test_helper, but the rest of the file still calls helper functions (e.g., initial_rdkfw_setup(), remove_file(), rename_file(), etc.) without the rdkfw_test_helper. prefix. This will raise NameError at runtime for most tests. Either restore the star import, or update all helper references to be fully qualified.

Suggested change

import rdkfw_test_helper

from rdkfw_test_helper import *

Copilot · 2026-03-11T14:39:48Z

-from pathlib import Path

-from rdkfw_test_helper import *
+import rdkfw_test_helper


The import was changed from from rdkfw_test_helper import * to import rdkfw_test_helper, but the rest of the test module still calls helper functions (e.g., initial_rdkfw_setup(), write_on_file(), remove_file(), etc.) without the rdkfw_test_helper. prefix. This will cause NameError at runtime. Either revert to the star import or qualify all helper calls.

Suggested change

import rdkfw_test_helper

from rdkfw_test_helper import *

Copilot · 2026-03-11T14:39:49Z

+    start_daemon()
    initial_rdkfw_setup()
    write_device_prop()
    cleanup_daemon_files()

    # Create mock firmware file
    firmware_name = "ABCD_PCI_test.bin"
-    firmware_path = create_mock_firmware_file(firmware_name)
+    create_mock_firmware_file(firmware_name)


start_daemon() return value is no longer captured, and this test no longer stops the daemon process or performs cleanup in a finally block. That leaves the daemon running across tests and can cause flakiness/port conflicts and resource leaks. Suggest restoring proc = start_daemon() and ensuring stop_daemon(proc) (and any temp file cleanup) always runs in finally:.

…or code 405

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…or code 405

* RDK-60640: Add PKCS#11 tests for mTLS certificate These tests ensure proper integration between device management service, certificate selector, and PKCS#11 token infrastructure. Background: RDK-60640 implements PKCS#11 support for storing private keys in hardware security modules (HSM) instead of filesystem. This enables production devices to use TPM/OP-TEE for secure key storage while maintaining mTLS connectivity to backend services. Changes: - Add test_pkcs11_fallback.py with 4 test scenarios - Test certificate chain fallback (primary → backup) - Validate mTLS handshake with PKCS#11-backed keys - Integration with SoftHSM2 for CI/test environments - Mock xconf endpoints for certificate validation Test Scenarios: 1. Primary certificate succeeds (happy path) 2. Primary fails, fallback to backup succeeds * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Resolve Copilot review comments and optimize test_pkcs11_fallback.py - Remove duplicate start_daemon/stop_daemon functions - Fix RFC file format: use json.dumps() instead of str() - Merge write_device_prop() and write_rfc_file() into write_config_files() - Improve process management with proper handle passing - Enhance backup_reference_cert fixture with pytest.skip() - Add OpenSSL validation with returncode check - Optimize file size from 363 to 163 lines (55% reduction) - Update run_l2.sh phase labels and descriptions for clarity * Remove test_verify_no_pkcs11_patch_activation from PKCS#11 fallback tests (not needed, key type is EC) * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Use DEVNULL for daemon stdout/stderr and cleanup /opt/curl_progress in fallback test * Fix test_fallback_rdkvfwupgrader_direct timeout: kill lingering daemon before running rdkvfwupgrader * Fix test_fallback_rdkvfwupgrader_direct: increase cleanup delay and kill rdkvfwupgrader to release curl connections * Fix test_fallback_rdkvfwupgrader_direct: use stdout=PIPE without timeout to match other tests * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Address all 3 Copilot review comments: - Capture daemon stdout/stderr for better error diagnostics - Use shutil.copy2/os.replace with exception handling in backup_reference_cert fixture - Add initial_rdkfw_setup to test_fallback_firmware_download for environment prerequisites * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update L2-tests.yml * Update test_pkcs11_fallback.py --------- Co-authored-by: “sahmad154” <sohail_ahmad@comcast.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Satya Sundar Sahu <tinkusahu.com@gmail.com>

…or code 405- adding L1 tests

Release 1.8.1

Signed-off-by: Yogeswaran K <yogeswaransky@gmail.com>

Copilot